Skip to content

Let the lede fill its column, and send the two tools to a new tab - #51

Merged
oblomov-dev merged 1 commit into
mainfrom
claude/abap2ui5-samples-nav-wrviw6
Aug 19, 2026
Merged

Let the lede fill its column, and send the two tools to a new tab#51
oblomov-dev merged 1 commit into
mainfrom
claude/abap2ui5-samples-nav-wrviw6

Conversation

@oblomov-dev

Copy link
Copy Markdown
Member

Two things a reader ran into on the finished bar.

The lede stopped short of its own page

.lede carried max-width: 62ch while everything under it — the filter panel, the cards, the packages section — ran the full 1132px column. The masthead therefore read as a paragraph of unfinished text rather than as the page's description, with the right third of it empty.

It has no max-width now and ends exactly where the column does. Measured rather than eyeballed: the lede spans 154 → 1286 and main's content box spans 154 → 1286, on all three pages.

The note under it — the one explaining why there is no Playground button on a card here — sits in the same masthead and loses its own 46rem for the same reason. So does the .three-lede above the card strip.

Playground and Docs open in a new tab

They are tools, not sibling pages: following one means leaving the catalogue you were reading, and coming back meant the back button. They now carry target="_blank" rel="noopener", which is what the outward arrow on them has been promising all along.

The three page links deliberately keep opening in place — switching between Learn, Controls and Stack is navigation within the family, not a departure from it.

Verification

Both blocks are still byte-identical across the three repositories — the CSS block verbatim, the nav HTML verbatim once aria-current is factored out (both checked mechanically, not by eye). Re-ran the full pass on all three pages, light and dark, at 1280px and 390px: right page marked, exactly one marker per block, no sideways scrolling (including the 390px case this page regressed on last round), no console errors, every landmark still starting at x = 154. check:web and check:family-nav pass.


Generated by Claude Code

Two things a reader ran into on the finished bar.

The lede stopped at 62ch while everything under it - the filter panel,
the cards, the packages - ran the full 1132px column, so the masthead
read as unfinished text rather than as the page's description. It has no
max-width now and ends exactly where the column does; measured, not
eyeballed: 154 to 1286 on all three pages, the same as the block below.
The note under it, which is part of the same masthead, loses its own
46rem for the same reason.

Playground and Docs are tools, not sibling pages: following one means
leaving the catalogue you were reading, and coming back meant the back
button. They open in a new tab now, which is what the outward arrow on
them has been promising. The three page links keep opening in place -
switching between Learn, Controls and Stack is navigation, not a
departure.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014QKMsbCiREgnpdfVvQYsa2
Copilot AI lite review requested due to automatic review settings August 19, 2026 15:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@oblomov-dev
oblomov-dev merged commit 84cbda2 into main Aug 19, 2026
22 checks passed
@oblomov-dev
oblomov-dev deleted the claude/abap2ui5-samples-nav-wrviw6 branch August 19, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants